Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ParamOverload annotation related improvements & bug fixes #1375

Merged
merged 3 commits into from Jul 5, 2019

Conversation

mohanvive
Copy link
Contributor

@mohanvive mohanvive commented Jul 4, 2019

Purpose

Fix the no param case when paramOverload annotation is in place
Improve error messages for paramOverload annotation

@codecov-io
Copy link

codecov-io commented Jul 4, 2019

Codecov Report

Merging #1375 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1375      +/-   ##
============================================
+ Coverage     60.52%   60.53%   +0.01%     
  Complexity       37       37              
============================================
  Files           632      632              
  Lines         26457    26482      +25     
  Branches       4183     4189       +6     
============================================
+ Hits          16012    16031      +19     
- Misses         9065     9070       +5     
- Partials       1380     1381       +1
Impacted Files Coverage Δ Complexity Δ
...l/extension/validator/InputParameterValidator.java 96.9% <100%> (+1.07%) 0 <0> (ø) ⬇️
...re/executor/function/CoalesceFunctionExecutor.java 80% <0%> (-13.34%) 0% <0%> (ø)
.../siddhi/core/util/event/handler/StreamHandler.java 62% <0%> (-12%) 0% <0%> (ø)
...java/io/siddhi/core/stream/input/InputHandler.java 77.41% <0%> (-3.23%) 0% <0%> (ø)
...o/siddhi/core/aggregation/IncrementalExecutor.java 81.1% <0%> (+0.78%) 0% <0%> (ø) ⬇️
...ut/stream/state/AbsentStreamPreStateProcessor.java 86.61% <0%> (+1.4%) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 292593d...da5fe78. Read the comment docs.

@mohanvive mohanvive changed the title Fix the no param case when paramOverload annotation is in place Fix the no param case when repetitive param exits in paramOverload annotation Jul 5, 2019
@mohanvive mohanvive changed the title Fix the no param case when repetitive param exits in paramOverload annotation ParamOverload annotation related improvements & bug fixes Jul 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants