Skip to content

Conversation

@evilaliv3
Copy link
Contributor

With this pull request i've implemented the following:

  1. first commit is a simple fix to issue 180
  2. the other commits implement a more complete solution that would require HumanizeDuration to integrate Implement support for issue #54 EvanHahn/HumanizeDuration.js#55

@EvanHahn here you can find the integration extension for HumanizeDuration

@EvanHahn
Copy link

.getSupportedLanguages() has been merged into the HumanizeDuration.js (as part of EvanHahn/HumanizeDuration.js#55), so it might be worth re-running the CI tests.

I didn't know about this library—glad to see someone integrating HumanizeDuration!

@evilaliv3
Copy link
Contributor Author

great @EvanHahn thanks! @siddii what about integrating this pull now that all is ready? :)

@siddii
Copy link
Owner

siddii commented May 10, 2015

@evilaliv3 - Can you fix the tests please?

@evilaliv3
Copy link
Contributor Author

sure @siddii

@evilaliv3
Copy link
Contributor Author

the issue was simply that we need to update the library. i'm going to test it!

@evilaliv3
Copy link
Contributor Author

here you go! done! automagically the test will now work :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants