Skip to content

Enh(#843): Allow signup flow return data when preventLoginFlow is true#903

Merged
phoenix-ru merged 21 commits into
sidebase:mainfrom
iamKiNG-Fr:enh/843-signup-flow-enhancement
Apr 10, 2025
Merged

Enh(#843): Allow signup flow return data when preventLoginFlow is true#903
phoenix-ru merged 21 commits into
sidebase:mainfrom
iamKiNG-Fr:enh/843-signup-flow-enhancement

Conversation

@iamKiNG-Fr

Copy link
Copy Markdown
Contributor

🔗 Linked issue

#843

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Added functionality to allow user receive response from server after signup, when preventLoginFlow is true.

image

📝 Checklist

  • I have linked an issue or discussion.
  • I have added tests (if possible).
  • I have updated the documentation accordingly.

@pkg-pr-new

pkg-pr-new Bot commented Sep 12, 2024

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@sidebase/nuxt-auth@903

commit: 653f80c

Comment thread src/runtime/types.ts Outdated
Comment thread src/runtime/composables/local/useAuth.ts Outdated
Comment thread playground-local/pages/register.vue Outdated
Comment thread playground-local/pages/register.vue Outdated
Comment thread playground-local/server/api/auth/signup.post.ts
Comment thread playground-local/tests/local.spec.ts Outdated
Comment thread src/runtime/composables/local/useAuth.ts Outdated
iamKiNG-Fr and others added 8 commits September 19, 2024 15:11
Co-authored-by: Marsel Shayhin <18054980+phoenix-ru@users.noreply.github.com>
…egResponse

Co-authored-by: Marsel Shayhin <18054980+phoenix-ru@users.noreply.github.com>
Co-authored-by: Marsel Shayhin <18054980+phoenix-ru@users.noreply.github.com>
Co-authored-by: Marsel Shayhin <18054980+phoenix-ru@users.noreply.github.com>
phoenix-ru
phoenix-ru previously approved these changes Apr 10, 2025
@phoenix-ru

Copy link
Copy Markdown
Member

Hi @iamKiNG-Fr
Thank you again for your PR! I pushed the missing changes and had another look at your changes.

I'll ask @zoey-kaiser to do a re-review and merge it

@zoey-kaiser zoey-kaiser dismissed their stale review April 10, 2025 15:23

Outdated

@phoenix-ru phoenix-ru merged commit fba0eea into sidebase:main Apr 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants