New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incompatible with newer versions of rufus-scheduler #199
Comments
Current version 3.5.0 has issues with sidekiq-cron sidekiq-cron/sidekiq-cron#199
|
+1 this is urgent |
|
May I suggest, as well, at
that |
|
Hello @JamesChevalier, I am the author of rufus-scheduler.
Would you have time to instrument a bit the following method in Sidekiq-Cron and tell me why it returns false? https://github.com/ondrejbartas/sidekiq-cron/blob/master/lib/sidekiq/cron/job.rb#L393-L412 I'm particulary interested in what gets stuffed into I don't have any Sidekiq (nor Redis) instance at hand, thanks in advance! |
|
@jmettraux This problem is affecting us as well. I was able to track down the error you were looking for |
Addresses sidekiq-cron#199 Sidekiq-cron is not using rufus-scheduler itself but rather its cron logic which recently got spun off in the fugit gem (https://github.com/floraison/fugit). This patch makes Sidekiq-cron depend directly on fugit instead of rufus-scheduler. A refinement would be to cache the parsed cron line in the Sidekiq-cron Job instance so that there is no need to reparse each time.
|
@brianstien Thanks a lot! I submitted a pull request that aligns Sidekiq-cron on fugit (the parsing lib behind rufus-scheduler >= 3.5 instead of rufus-scheduler). http://jmettraux.skepti.ch/20180515.html?t=rufus_scheduler_3_5_0_released |
|
This also happened to us with:
Suddenly all of our cron jobs were not being enqueued anymore |
|
I got around this by adding this to my Gemfile gem 'rufus-scheduler', '~> 3.4.0' |
|
Yet another reminder: https://bundler.io/v1.16/guides/updating_gems.html Updating your dependency gem versions is something you do deliberately, with your back covered by your test suite. http://jmettraux.skepti.ch/20180601.html?t=Gemfile_lock&f=gh |
it stopped working due to incompatible new version of rufus-scheduler, see sidekiq-cron/sidekiq-cron#199
it stopped working due to incompatible new version of rufus-scheduler, see sidekiq-cron/sidekiq-cron#199
|
Any news? |
|
I just installed version 1.0.0 and it fixed the mentioned error for me |
|
Upgraded to 1.0.0 and it seems to fix the issue. |
|
@ondrejbartas Could you please close this issue and also its duplicates: gh-201 and gh-206? |
|
@lucascaton Yes, people are giving feedback and coming with suggestions at gh-202, gh-209, gh-210, and gh-213. Since it's not related to "Incompatible with newer versions of rufus-scheduler" (this issue), the conversation is happening elsewhere. |
|
Thanks :) |
|
If it seems to be corrected, could you please close this issue. |

This gem works with rufus-scheduler version 3.4.2 but does not work with version 3.5.0
While using version 3.5.0, attempting
Sidekiq::Cron::Job.createcalls returnsfalse, and the job is not added.My only guess to the cause is that according to the changelog, rufus-scheduler now uses fugit to parse durations and cronlines.
I looked for instances of
parse_time_stringandparse_duration_stringin this repository, and didn't find any - so it doesn't appear that their removal is playing a part here.The text was updated successfully, but these errors were encountered: