Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipelining commands on a Redis instance is deprecated and will be removed in Redis 5.0.0 (WARNING) #5178

Closed
NemyaNation opened this issue Feb 4, 2022 · 14 comments

Comments

@NemyaNation
Copy link

Ruby version: ruby 2.6.6p146
Rails version: Rails 6.1.3.1
Sidekiq / Pro / Enterprise version(s): 6.4.0

This just started a coulple of hours ago, approximiately ever 2s I get more than 100 lines of this warning repeated again and again since the latest update to (6.4.0)

warning in logs:

app[web] info redis.pipelined do
app[web] info   redis.get("key")
app[web] info end
app[web] info
app[web] info should be replaced by
app[web] info
app[web] info redis.pipelined do |pipeline|
app[web] info   pipeline.get("key")
app[web] info end
app[web] info
app[web] info (called from /app/vendor/bundle/ruby/2.7.0/gems/sidekiq-6.4.0/lib/sidekiq/api.rb:57:in `block in fetch_stats_fast!'}
Feb 4 00:09:38 my-app app[web] info Pipelining commands on a Redis instance is deprecated and will be removed in Redis 5.0.0.

initializers/sidekiq.rb

Sidekiq.configure_server do |config|
	config.redis = {
		url: ENV["REDISCLOUD_URL"]
	}
end

Sidekiq.configure_client do |config|
	config.redis = {
		url: ENV["REDISCLOUD_URL"],
		size: 2
	}
end

Sidekiq.strict_args!(false)

Still clogging up my logs, and this is just from live polling on the dashboard.

I thought it might be fixed by adding Sidekiq.strict_args!(false) but this did not help, doesn't look like it's from my end and instead something needs to be updated in the gem itself?

@mperham
Copy link
Collaborator

mperham commented Feb 4, 2022 via email

@NemyaNation
Copy link
Author

@mperham brilliant, no I'll wait, I just was wondered if you guys were aware the latest update was causing this warning.

will leave open until monday and I see that the warning has subsided.

@resistorsoftware
Copy link

I just updated to Sidekiq 6.4.1 and running Rails 7 with Redis 4.6, this is still an issue. Logs fill continuously with notice about using pipeline key.

@mperham
Copy link
Collaborator

mperham commented Feb 8, 2022

Do you use any other Sidekiq extensions?

@seanwmitchell
Copy link

Thanks for the fix, my logs are empty now. Rail 7.0.1, Sidekiq 6.4.1, sidekiq-congestion 0.1.1 and Redis 4.6.0 on Ubuntu 20.04.3 LTS.

@resistorsoftware
Copy link

Do you use any other Sidekiq extensions?

No. My gemfile is "redis" and "sidekiq"

@resistorsoftware
Copy link

Do you use any other Sidekiq extensions?

No. My gemfile is "redis" and "sidekiq"

Ack. NVM...

Was just a bad bundle

@celsoMartins
Copy link

celsoMartins commented Feb 9, 2022

I'm also still getting the warning on my logs.

This is the env information.

redis-server --version
Redis server v=6.2.6 sha=00000000:0 malloc=libc bits=64 build=c6f3693d1aced7d9
gem list|grep sidekiq
sidekiq (6.4.1)
sidekiq-limit_fetch (3.4.0)
Pipelining commands on a Redis instance is deprecated and will be removed in Redis 5.0.0.

redis.multi do
  redis.get("key")
end

should be replaced by

redis.multi do |pipeline|
  pipeline.get("key")
end
gem 'sidekiq'
gem 'sidekiq-limit_fetch'

and the redis was installed using homebrew.

@petergoldstein
Copy link
Contributor

@celsoMartins It's in sidekiq-limit_fetch. I just put up a PR to resolve - deanpcmad/sidekiq-limit_fetch#121

@vinc
Copy link

vinc commented Feb 9, 2022

The following PRs have been opened by people experiencing the same issue in other gems:

@kimpastro
Copy link

gem redis 4.6 and sidekiq 6.4.1 works for me.

@pinkyrout
Copy link

pinkyrout commented Feb 24, 2022

I am still getting the warnings after upgrading sidekiq from 4.2.10 to 6.4.1 or 6.4.0 and even tried using the main branch from Sidekiq.
My ruby version is 2.7.5 and Rails version is 6.0 . Redis gem version is 4.6.0 .

@Laykou
Copy link

Laykou commented Feb 24, 2022

It may be due to other gems, in my case it was sidekiq-cron. Here is a discussion and fix in forked branch: sidekiq-cron/sidekiq-cron#310 (comment)

@pinkyrout
Copy link

Thanks, it worked for me. The issue was with sidekiq-cron.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

10 participants