-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for the apns-push-type header #139
Conversation
Curious if we're planning to merge this or #138? Trying to test something with iOS 13 now. Would be great to get either into |
Same here - @sideshow do you think this pull is mergable? 🙏 |
Removes support for golang 1.6 so we can better support new features moving forward
referring to the docs: https://developer.apple.com/documentation/usernotifications/setting_up_a_remote_notification_server/generating_a_remote_notification the code is correct putting it into the alert, but the docs are (as often is ^^) wrong
Hey @wiggisser thanks for the PR, this looks great. I would like to merge this but any change you could rebase of master? - this should fix the tests. Once i've done a smoke test on ios12 and 13 I will merge. Thanks again! |
@sideshow I did a rebase on the latest master from the upstream repository, but I'm not sure about what to do with the failing checks ... |
@sideshow Would be awesome to merge this week 👍🏻 |
Howdy folks. I've inherited a service at my company that uses this library and I'm getting some pressure to add support for |
It looks like the build may have failed due to a temporary network request issue. Could someone with write access rerun travis-ci? |
Thanks again for this PR, Tests are now passing and I have smoke tested on iOS 13 beta. It looks like apple aren't yet enforcing the requirement for this header on the iOS 13 beta. PR works with these headers but it also works without it. |
fixes #137