Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the apns-push-type header #139

Merged
merged 7 commits into from
Aug 17, 2019
Merged

Add support for the apns-push-type header #139

merged 7 commits into from
Aug 17, 2019

Conversation

wiggisser
Copy link
Contributor

@wiggisser wiggisser commented Jun 18, 2019

fixes #137

@coveralls
Copy link

coveralls commented Jun 18, 2019

Coverage Status

Coverage decreased (-0.2%) to 91.897% when pulling 83c62f4 on wiggisser:apns-push-type into d5157a5 on sideshow:master.

@benguild
Copy link

Curious if we're planning to merge this or #138? Trying to test something with iOS 13 now.

Would be great to get either into master.

@froodian
Copy link
Contributor

Same here - @sideshow do you think this pull is mergable? 🙏

Removes support for golang 1.6 so we can better support new features
moving forward
referring to the docs: https://developer.apple.com/documentation/usernotifications/setting_up_a_remote_notification_server/generating_a_remote_notification

the code is correct putting it into the alert, but the docs are (as often is ^^) wrong
@sideshow
Copy link
Owner

Hey @wiggisser thanks for the PR, this looks great.

I would like to merge this but any change you could rebase of master? - this should fix the tests.

Once i've done a smoke test on ios12 and 13 I will merge.

Thanks again!

@wiggisser
Copy link
Contributor Author

@sideshow I did a rebase on the latest master from the upstream repository, but I'm not sure about what to do with the failing checks ...

@benguild
Copy link

@sideshow Would be awesome to merge this week 👍🏻

@adamcodes
Copy link

Howdy folks. I've inherited a service at my company that uses this library and I'm getting some pressure to add support for apns-push-type ahead of the iOS 13 release. Would friendly encouragement or a bribe help get this PR completed and merged? 🙇

@adamcodes
Copy link

It looks like the build may have failed due to a temporary network request issue. Could someone with write access rerun travis-ci? On the build's detail screen, there is a button ↻ with the tooltip "Restart Build".

@sideshow
Copy link
Owner

Thanks again for this PR, Tests are now passing and I have smoke tested on iOS 13 beta. It looks like apple aren't yet enforcing the requirement for this header on the iOS 13 beta. PR works with these headers but it also works without it.

@sideshow sideshow merged commit 88a36b9 into sideshow:master Aug 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

iOS 13 feature support
6 participants