Skip to content

Sidharth Kshatriya
sidkshatriya

  • Joined on Feb 25, 2011
Jul 1, 2016
@sidkshatriya

@karens FYI I've added a short note to the README of 8.x If you're not using Composer Manager, you may run into a composer error in which you're u…

Jul 1, 2016
@sidkshatriya
  • @sidkshatriya 3b4d557
    README.md: Add a note on caching
Jul 1, 2016
@sidkshatriya
  • @sidkshatriya a0f371c
    README.md: Add a note on test coverage
Jul 1, 2016
@sidkshatriya
Add some documentation for `src/Validate` directory
Jul 1, 2016
@sidkshatriya

Documentation was written. See here: https://github.com/Lullabot/amp-library/tree/master/src/Validate Closing.

Jul 1, 2016
@sidkshatriya
Add some documentation for `src/Validate` directory
Jul 1, 2016
sidkshatriya commented on pull request sabberworm/PHP-CSS-Parser#105
@sidkshatriya

@sabberworm Thanks for responding and eagerly look forward to some basic media query parsing. Also to my previous question: is your parsing algori…

Jul 1, 2016
@sidkshatriya
  • @sidkshatriya 6a8b9ea
    Create a README.md for the `src/Validate` folder
Jul 1, 2016
@sidkshatriya
CSS validation (css_spec validation)
Jul 1, 2016
@sidkshatriya

Since the last few days I've looked at this issue carefully and discussed this. The objective of this note is to summarize where we stand. Currentl…

Jul 1, 2016
@sidkshatriya
Modifications to support line numbers within CSS
Jul 1, 2016
@sidkshatriya

With: Merge of PR #80 Merge of our sabberworm/PHP-CSS-Parser#105 and subsequent release of 8.0.0 This ticket can be now closed.

Jul 1, 2016
sidkshatriya commented on pull request Lullabot/amp-library#80
@sidkshatriya

This was merged to master. It uses the latest version ^8.0.0 of the sabberworm css parser which contains our patch for line numbers

Jul 1, 2016
@sidkshatriya
  • @sidkshatriya 04c9c93
    Merge pull request #80 from Lullabot/79-line-numbers-css-issues
  • @sidkshatriya 2c07a36
    Instead of deltas, use the concept of line overrides. Simpler logic a…
  • 15 more commits »
sidkshatriya deleted branch 79-line-numbers-css-issues at Lullabot/amp-library
Jul 1, 2016
Jul 1, 2016
@sidkshatriya
79 line numbers css issues
16 commits with 58 additions and 30 deletions
Jul 1, 2016
@sidkshatriya
  • @sidkshatriya 2c07a36
    Instead of deltas, use the concept of line overrides. Simpler logic a…
  • @sidkshatriya 1e4e2dd
    We want to start off with line number 0 as we are using a delta based…
  • 1 more commit »
Jun 30, 2016
sidkshatriya commented on pull request sabberworm/PHP-CSS-Parser#105
@sidkshatriya

@sabberworm sorry for persisting but I just want to be aware of any parse related aborts due to syntax the parser does not understand. Like I menti…

Jun 30, 2016
@sidkshatriya
  • @sidkshatriya 19e4f4b
    Switch to dev-master as line number PR was merged
Jun 30, 2016
@sidkshatriya
Jun 30, 2016
sidkshatriya commented on pull request sabberworm/PHP-CSS-Parser#105
@sidkshatriya

@sabberworm Is your parser hand built or have you consulted something like https://drafts.csswg.org/css-syntax-3/ for your tokenizing/parsing algo…

Jun 30, 2016
@sidkshatriya

The sabberworm PR was merged to master

Jun 30, 2016
sidkshatriya commented on pull request sabberworm/PHP-CSS-Parser#105
@sidkshatriya

as Lullabot re: selector and media query parsing -- I could look at it in my spare time. If you make a ticket chalking out the details on whats inc…

Jun 30, 2016
sidkshatriya commented on pull request sabberworm/PHP-CSS-Parser#105
@sidkshatriya

@sabberworm Ah you merged! Great! Thanks so much!

Jun 30, 2016
sidkshatriya commented on pull request sabberworm/PHP-CSS-Parser#105
@sidkshatriya

@sabberworm This was a fantastic catch! Sorry I didn't notice the extraneous $

Jun 30, 2016
sidkshatriya commented on pull request sabberworm/PHP-CSS-Parser#105
@sidkshatriya

Done

Jun 30, 2016
sidkshatriya commented on pull request sabberworm/PHP-CSS-Parser#105
@sidkshatriya

@sabberworm done.

Jun 30, 2016
@sidkshatriya
Jun 30, 2016
@sidkshatriya

Made a huge amount of progress on sabberworm/PHP-CSS-Parser#105 See the PR for changes. Hopefully it should not take too long to get this change a…

Jun 30, 2016
sidkshatriya commented on pull request sabberworm/PHP-CSS-Parser#105
@sidkshatriya

@sabberworm Hopefully things are now looking good. Let me know if you have any other suggestions (thanks for your really responsive help on this!). …

Something went wrong with that request. Please try again.