New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default CE pin from 16 to 4 #371

Merged
merged 3 commits into from Jan 4, 2019

Conversation

Projects
None yet
2 participants
@slootjes
Copy link
Contributor

slootjes commented Jan 3, 2019

Turns out I didn't properly read your proposed changes in #367 as currently the description is "from 4 to 16" while it should be the other way around. The default is set to GPIO 16 and it needs to be changed to GPIO 4 to work when following the linked guide to install the antenna. As you stated there is no real reason GPIO 16 is picked by default I think it would save others some headaches (just like me) if it changed to GPIO 4. I've also removed the additional copy added to the README.md as this was wrong and correcting it would no longer be required.

slootjes added some commits Jan 3, 2019

@sidoh
Copy link
Owner

sidoh left a comment

Left a small suggestion. I'll want to update my blog post as well when we merge this.

Another reason to make this change is that D0/GPIO16 is low on boot, whereas D2/GPIO4 is not. In other words, D2/GPIO4 is just a slightly better i/o pin.

Show resolved Hide resolved README.md Outdated
Update README.md
Co-Authored-By: slootjes <robertslootjes@gmail.com>
@slootjes

This comment has been minimized.

Copy link
Contributor

slootjes commented Jan 4, 2019

Good suggestion, I've committed it 👍

@sidoh sidoh merged commit 60c924c into sidoh:master Jan 4, 2019

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@sidoh

This comment has been minimized.

Copy link
Owner

sidoh commented Jan 4, 2019

Thanks for your help in improving documentation and approachability of this project! Much appreciated :)

@sidoh

This comment has been minimized.

Copy link
Owner

sidoh commented Jan 4, 2019

Tagged this as the 1.8.6 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment