fixed to use safe-iterative method & remove hasOwnProperty() #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Awesome. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hi, I was searching for light venn diagram library and I found your work. first, thanks for your great work.
however, I found it wasn't working properly although it worked well in standalone example. I tried debugging and I found there was collision with
jquery.bootstrap.js.So my modification summarization:
(don't use directionary-based iteration; because of Array.prototype)
(it doesn't recognize offsetY attr existence, maybe some library overlapped)
After that it started to work properly with jquery & bootstrap combination. Also I minified edited js with javascript minifier.
Regards, kuna.