New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed to use safe-iterative method & remove hasOwnProperty() #1

Merged
merged 1 commit into from Mar 10, 2017

Conversation

Projects
None yet
2 participants
@kuna
Copy link
Contributor

kuna commented Mar 10, 2017

hi, I was searching for light venn diagram library and I found your work. first, thanks for your great work.
however, I found it wasn't working properly although it worked well in standalone example. I tried debugging and I found there was collision with jquery.bootstrap.js.
So my modification summarization:

  1. use safe iterative method
    (don't use directionary-based iteration; because of Array.prototype)
  2. hasOwnProperty() in handleVennClick()
    (it doesn't recognize offsetY attr existence, maybe some library overlapped)

After that it started to work properly with jquery & bootstrap combination. Also I minified edited js with javascript minifier.
Regards, kuna.

@sidoh

This comment has been minimized.

Copy link
Owner

sidoh commented Mar 10, 2017

Awesome. Thank you!

@sidoh sidoh merged commit 9202513 into sidoh:master Mar 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment