-
-
Notifications
You must be signed in to change notification settings - Fork 612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
typeCast is up to 10x slower #889
Comments
5 tasks
This was referenced Oct 6, 2021
@gbelur Can you try with 2.3.3-rc0 to see if it is ok now? |
I thought I fixed this already @sidorares |
I thought so as well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When the typeCast option is used, queries tend to run up to 10x slower under load. A perf profile shows that most of the additional time is spent in column_defintion.js obtaining the schema and table name in the code below:
These fields are meant to be computed lazily, but end up getting recomputed for every field access as part of the 'wrap' function implementation that needs field.schema, field.table and field.name
Given that these fields are used for every column, can these be precomputed?
The text was updated successfully, but these errors were encountered: