refactor: convert columns to signal input #518
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the columns property from a decorator-based @Input to a signal-based input. To handle internal column modifications (like width changes), _internalColumns is introduced as a linkedSignal that derives from either column templates or the columns input.
Key Changes:
- Converted
columnsfrom@Inputgetter/setter toinput<TableColumn[]>() - Introduced
_internalColumnsas alinkedSignalto handle mutable column state - Updated
recalculateColumnsmethod signature to require columns parameter and returnTableColumnInternal[] - Updated all references to
_internalColumnsto call it as a signal function
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| projects/ngx-datatable/src/lib/components/datatable.component.ts | Refactored columns to signal input, introduced linkedSignal for internal columns, updated method signatures and all column references |
| projects/ngx-datatable/src/lib/components/datatable.component.html | Updated template bindings to call _internalColumns() as a signal function |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
projects/ngx-datatable/src/lib/components/datatable.component.ts
Outdated
Show resolved
Hide resolved
projects/ngx-datatable/src/lib/components/datatable.component.ts
Outdated
Show resolved
Hide resolved
projects/ngx-datatable/src/lib/components/datatable.component.ts
Outdated
Show resolved
Hide resolved
This is just an intermediate solution, so that we can turn the `columns` into a signal input. Since we internally mutate the columns, `_internalColumns` has to be a `linkedSignal`. We should consider alternative approaches, that only use computed.
spike-rabbit
force-pushed
the
refactor/columns-to-linked-signal
branch
from
33f77f3 to
d29d76a
Compare
fh1ch
approved these changes
Nov 17, 2025
Member
fh1ch
left a comment
fh1ch
left a comment
There was a problem hiding this comment.
@spike-rabbit thanks a ton for the rework, all good now 🙇
LGTM 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check one with "x")
What is the current behavior? (You can also link to an open issue here)
columnsare a decorator based input.What is the new behavior?
columnsare a signal input._internalColumnsare linkedSignal to allow modifications.Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications:
Other information:
This is just an intermediate solution, so that we can turn the
columnsinto a signal input.Since we internally mutate the columns,
_internalColumnshas to be alinkedSignal. We should consider alternative approaches, that only use computed.