Skip to content

Conversation

@hrntknr
Copy link
Member

@hrntknr hrntknr commented Dec 4, 2025

…debian:bookworm-slim

Summary

(Brief description of what this PR accomplishes)

Type of Change

  • feat: A new feature
  • fix: A bug fix
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • refactor: A code change that neither fixes a bug nor adds a feature
  • perf: A code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to our CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit

Related Issues

Copilot AI review requested due to automatic review settings December 4, 2025 15:02
@hrntknr hrntknr merged commit dbeabda into main Dec 4, 2025
7 checks passed
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Docker configuration to use more recent and standardized base images. The build stage switches from Alpine-based Go to Debian Bookworm with Go 1.22, while the runtime stage moves from Alpine to Debian Bookworm slim.

Key Changes:

  • Updated build base image from golang:alpine to golang:1.22-bookworm
  • Changed runtime base image from alpine:latest to debian:bookworm-slim
  • Modified package installation to use Debian's apt-get instead of Alpine's apk

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

FROM debian:bookworm-slim

RUN apt-get update && apt-get install -y --no-install-recommends \
ca-certificates curl python3 python3-pip nodejs npm \
Copy link

Copilot AI Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The package curl is installed but may not be necessary for the application's runtime. Consider removing it if it's not actively used, as it increases the attack surface and image size.

Suggested change
ca-certificates curl python3 python3-pip nodejs npm \
ca-certificates python3 python3-pip nodejs npm \

Copilot uses AI. Check for mistakes.

RUN apt-get update && apt-get install -y --no-install-recommends \
ca-certificates curl python3 python3-pip nodejs npm \
&& rm -rf /var/lib/apt/lists/*
Copy link

Copilot AI Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Alpine version used uv (a fast Python package installer), but the Debian version installs python3-pip instead. If uv was intentionally chosen for performance or specific functionality, consider installing it explicitly in the Debian image to maintain equivalent functionality.

Suggested change
&& rm -rf /var/lib/apt/lists/*
&& rm -rf /var/lib/apt/lists/* \
&& curl -Ls https://github.com/astral-sh/uv/releases/latest/download/uv-x86_64-unknown-linux-gnu.tar.gz -o /tmp/uv.tar.gz \
&& tar -xzf /tmp/uv.tar.gz -C /tmp \
&& mv /tmp/uv /usr/local/bin/uv \
&& chmod +x /usr/local/bin/uv \
&& rm /tmp/uv.tar.gz

Copilot uses AI. Check for mistakes.
@codecov
Copy link

codecov bot commented Dec 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants