Add mj-include support and eliminate tempfiles #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eliminate temp files for in/out - use stdin/stdout instead
|
@drush Sorry about the GitHub Action failures - should be fixed on |
|
@drush Are you still planning on fixing the failing tests? https://github.com/sighmon/mjml-rails/actions/runs/4001787672/jobs/6869100076?pr=100 |
|
Would very much like this PR included! |
|
@johnhuang121 Would you like to take this PR over fixing the tests and adding it as optional via a configuration variable? |
|
I can take a look at this, but not sure if I can take this over yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has two significant improvements:
<mj-include />is now supported. This allows it to be used in VS Code with full preview support and during runtime.mjmlcommand.