From 28d60759aea2b1cb0af850ef7874657e2b057404 Mon Sep 17 00:00:00 2001 From: Alessio Pragliola Date: Tue, 23 Jan 2024 17:42:35 +0100 Subject: [PATCH] fix: removed error when upgrading with reducer --- .../kfd/v1alpha2/common/create/preupgrade.go | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/internal/apis/kfd/v1alpha2/common/create/preupgrade.go b/internal/apis/kfd/v1alpha2/common/create/preupgrade.go index 30bae5bcd..f1e55b8d0 100644 --- a/internal/apis/kfd/v1alpha2/common/create/preupgrade.go +++ b/internal/apis/kfd/v1alpha2/common/create/preupgrade.go @@ -29,12 +29,11 @@ import ( ) var ( - errUpgradeCanceled = errors.New("upgrade canceled by user") - errUpgradeFlagNotSet = errors.New("upgrade flag not set by user") - errUpgradeWithReducersNotAllowed = errors.New("upgrade with reducers not allowed") - errUpgradePathNotFound = errors.New("upgrade path not found") - errGettingDistroVersionFrom = errors.New("error while getting distribution version from") - errGettingDistroVersionTo = errors.New("error while getting distribution version to") + errUpgradeCanceled = errors.New("upgrade canceled by user") + errUpgradeFlagNotSet = errors.New("upgrade flag not set by user") + errUpgradePathNotFound = errors.New("upgrade path not found") + errGettingDistroVersionFrom = errors.New("error while getting distribution version from") + errGettingDistroVersionTo = errors.New("error while getting distribution version to") ) type PreUpgrade struct { @@ -216,9 +215,10 @@ func (p *PreUpgrade) Exec() error { return fmt.Errorf("error checking upgrade path: %w", err) } - if len(p.reducers) > 0 { - return errUpgradeWithReducersNotAllowed - } + // We should find a smarer way to stop the process if the reducers are from the upgrade or not + // if len(p.reducers) > 0 { + // return errUpgradeWithReducersNotAllowed + // }. if !p.forceFlag { if _, err := fmt.Println("Are you sure you want to continue? Only 'yes' will be accepted to confirm."); err != nil {