Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[trade] redesign receipt #200

Closed
generalpiston opened this Issue Feb 2, 2019 · 3 comments

Comments

Projects
None yet
2 participants
@generalpiston
Copy link
Collaborator

generalpiston commented Feb 2, 2019

Receipts for:

  • Fill order
  • Limit order
  • Send tokens
  • Send ethereum
  • lock/unlock
  • Wrap/Unwrap ethereum

Details:

  • Relayer: fee, fee token
  • Network: gas, gas price, total network fee
  • Order Details: price, amount, side
  • Sending: tokens, amount
  • Receiving: tokens, amount
  • Wallet: network fee amount, relayer fee amount, receive token amount, send token amount
  • After Transaction Wallet: network fee amount, relayer fee amount, receive token amount, send token amount
  • Expiration time

@generalpiston generalpiston self-assigned this Feb 2, 2019

generalpiston added a commit that referenced this issue Feb 3, 2019

@AboShanab

This comment has been minimized.

Copy link
Contributor

AboShanab commented Feb 3, 2019

Suggestions:

  • Network:
    value -> Transaction value
    Fee -> Tx Fee
    The first field needs a description label with calling it Gas Limit
  • Relayer:
    Fees -> Trade Fees
  • Order:
    Receiving -> Buying/Selling (depends on the side)
@generalpiston

This comment has been minimized.

Copy link
Collaborator Author

generalpiston commented Feb 4, 2019

Expiration time will be handled in #185.

@generalpiston generalpiston added this to the 0.9.4 milestone Feb 4, 2019

generalpiston added a commit that referenced this issue Feb 4, 2019

generalpiston added a commit that referenced this issue Feb 14, 2019

generalpiston added a commit that referenced this issue Feb 24, 2019

generalpiston added a commit that referenced this issue Feb 24, 2019

@generalpiston

This comment has been minimized.

Copy link
Collaborator Author

generalpiston commented Feb 24, 2019

Moving lock to a new ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.