Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"next" branch breaks gist.el ability to edit description #75

Closed
sigma opened this issue Jun 26, 2016 · 1 comment
Closed

"next" branch breaks gist.el ability to edit description #75

sigma opened this issue Jun 26, 2016 · 1 comment
Assignees
@sigma
Milestone
v1.0

Comments

@sigma
Copy link
Owner

sigma commented Jun 26, 2016

No description provided.

@sigma sigma added this to the v1.0 milestone Jun 26, 2016
@sigma
Copy link
Owner Author

sigma commented Jun 26, 2016

problem is in serialization. PATCH request has following body:

"{\"description\":\"minimal redis docker image with nix\",\"public\":true,\"files\":null}"

When it really needs to be:

"{\"description\":\"minimal redis docker image with nix\",\"public\":true,\"files\":{}}"

so somehow null needs to be converted to empty dict

sigma added a commit that referenced this issue Jun 26, 2016
@sigma
don't put files in the json object if it's null
67af6f9 
fixes #75
@sigma sigma closed this as completed Jun 26, 2016
@sigma sigma self-assigned this Jun 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sigma sigma

Labels
None yet
Projects
None yet
Milestone
v1.0
Development

No branches or pull requests
1 participant
@sigma