enforce indent-tabs-mode is disabled #7

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
@tarsius
Contributor

tarsius commented Apr 29, 2012

No description provided.

@sigma

This comment has been minimized.

Show comment Hide comment
@sigma

sigma May 1, 2012

Owner

I'm not a fan of having that kind of files under version control, as people might want to put their very own settings there.
If we really need such things, better put local variables in each file :)

Owner

sigma commented May 1, 2012

I'm not a fan of having that kind of files under version control, as people might want to put their very own settings there.
If we really need such things, better put local variables in each file :)

@sigma sigma closed this May 1, 2012

@tarsius

This comment has been minimized.

Show comment Hide comment
@tarsius

tarsius May 2, 2012

Contributor

Well, I just copied that file from magit ;-)

I think it's needed. Remember you had to fix whitespace errors in a recent pull request by me? :-) I can't just set the default value of indent-tabs-mode to nil as most elisp files I edit actually contain tabs.

Three lines in each file then. If you depart from the default then you have to enforce it.

Contributor

tarsius commented May 2, 2012

Well, I just copied that file from magit ;-)

I think it's needed. Remember you had to fix whitespace errors in a recent pull request by me? :-) I can't just set the default value of indent-tabs-mode to nil as most elisp files I edit actually contain tabs.

Three lines in each file then. If you depart from the default then you have to enforce it.

@sigma

This comment has been minimized.

Show comment Hide comment
@sigma

sigma May 2, 2012

Owner

Well if it was up to me, the magit one would disappear ;)

Of course I understand your concern, but I guess I'd simply encourage you to actually use this .dir-locals.el in your working copy and git ignore it.
I mean, for now I'm fine with occasionally fixing incoming code, that's a normal part of my code review process.
But yeah, I'll consider adding file-level local variables.

Owner

sigma commented May 2, 2012

Well if it was up to me, the magit one would disappear ;)

Of course I understand your concern, but I guess I'd simply encourage you to actually use this .dir-locals.el in your working copy and git ignore it.
I mean, for now I'm fine with occasionally fixing incoming code, that's a normal part of my code review process.
But yeah, I'll consider adding file-level local variables.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment