Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upWIP: Use a default title if none specified #46
Conversation
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
alexander-yakushev
Oct 19, 2015
Collaborator
@stig Sorry for postponing this, I will merge this PR as soon as the dust settles after the recent rewrites. Thank you!
|
@stig Sorry for postponing this, I will merge this PR as soon as the dust settles after the recent rewrites. Thank you! |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
stig
Oct 19, 2015
Nono! Please don't merge it in its current state :-D it does more harm than good in its current state :-)
stig
commented
Oct 19, 2015
|
Nono! Please don't merge it in its current state :-D it does more harm than good in its current state :-) |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
stig
Oct 19, 2015
It's just a placeholder at the moment. I've managed to identify the place I want to inject some code, but I don't know what to inject :-D
stig
commented
Oct 19, 2015
|
It's just a placeholder at the moment. I've managed to identify the place I want to inject some code, but I don't know what to inject :-D |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
alexander-yakushev
Oct 19, 2015
Collaborator
As you wish. I will take some time later to think about this and suggest something better. I suppose what you want is #41?
|
As you wish. I will take some time later to think about this and suggest something better. I suppose what you want is #41? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
stig
Oct 19, 2015
Exactly that. I just wanted to show that I cared enough to make at least a token effort, but I got stuck trying to figure out how to get the information I wanted from magit.
stig
commented
Oct 19, 2015
|
Exactly that. I just wanted to show that I cared enough to make at least a token effort, but I got stuck trying to figure out how to get the information I wanted from magit. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
This should be closed following the merge of #71. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
alexander-yakushev
closed this
Dec 12, 2015
alexander-yakushev
added
the
duplicate
label
Dec 12, 2015
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
stig
Dec 12, 2015
Thanks so much, this will make a big difference to my day-to-day work :-)
Sent from my iPhone
On 12 Dec 2015, at 18:33, Alexander Yakushev notifications@github.com wrote:
Closing this as resolved. @stig, thanks for your effort! I'm sorry I didn't have time to work this through together with you. And thanks to @thieman for finally implementing this!
—
Reply to this email directly or view it on GitHub.
stig
commented
Dec 12, 2015
|
Thanks so much, this will make a big difference to my day-to-day work :-) Sent from my iPhone
|
stig commentedSep 3, 2015
This is WIP, and a request for help -- I do not expect it to be merged in its current form.
I wanted to try to address issue #41, as this would simplify my workflow a lot. (I do a lot of single-commit PRs.) It was relatively easy to get this far, but I've just spent a couple hours fruitlessly reading through magit's docs & source, attempting to figure out how to get the summary from the first commit that is different between the two branches. (Much like github does when you set up a pull request there.) This being my first attempt at contributing to an Elisp package, I would really love some help if possible.
(I suppose an extension of this would be to use magit's
with-editor-- I'm wondering if one then could get the benefit ofM-pto simply recall the last commit message? That would sort me out.)