Store number of additions and deletions on a Pull Request #84

Merged
merged 1 commit into from Mar 29, 2013

Conversation

Projects
None yet
1 participant
@ghost

ghost commented Mar 29, 2013

I've noticed that the Pull Request instances don't store the number of
additions and deletions and I've added it since the GitHub API returns
those numbers in the response.

ghost closed this Mar 29, 2013

@ghost

ghost commented Mar 29, 2013

Apparently the additions and deletions are not returned in the payload anymore, although the docs
aren't updated.

Owner

sigmavirus24 commented Mar 29, 2013

They're on the object I call PullFiles I think. I'm not at a computer though so I might be wrong.

@ghost

ghost commented Mar 29, 2013

Yes, I summed up the additions and deletions for each PullFile.

Owner

sigmavirus24 commented Mar 29, 2013

Actually, did you test it on a PullRequest object returned from an iter_ method or on one you requested with a specific number? The latter should have it, not the former.

sigmavirus24 reopened this Mar 29, 2013

@sigmavirus24 sigmavirus24 merged commit 5b0f802 into sigmavirus24:develop Mar 29, 2013

1 check was pending

default The Travis build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment