-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
Description
- I have searched open and closed issues for duplicates
- I am submitting a bug report for existing functionality that does not work as intended
- I have read https://github.com/signalapp/Signal-Android/wiki/Submitting-useful-bug-reports
- This isn't a feature request or a discussion topic
Bug description
When creating backups using the "Chat backups" feature the resulting backup files don't appear to be deduplicated. They can be vastly bigger than the actual data used by the Signal app. Forwarding messages inflates backup size while Signal App Data Size does not change.
Steps to reproduce
- Send a large-ish file or media (a couple megabytes)
- Create a backup and note down: Backup size & Signal app data usage
- Forward the file one or more times
- Create another backup, then compare backup sizes & Signap app data usage
Actual result: The Backup file size increases by the size of the forwarded file while Signal App usage does not. For example, in the case of another persons Signal i observed 400MB of app data usage while the backup file size was about 1GB.
Expected result: If Signal deduplicates forwarded messages internally they should also be deduplicated in backup files. The backup file should not be considerably larger than Signals app data.
Device info
Device: Xiaomi Redmi 4X
Android version: LineageOS 15.1 based on AOSP 8.1.0
Signal version: 5.18.5
Link to debug log
https://debuglogs.org/bb268c5fb8102c6c3430235813b64721c100dec8c3ac8dfe71885073a2133fc1