Crash attempting to forward errored message

[wesinator]

• I have searched open and closed issues for duplicates
• I am submitting a bug report for existing functionality that does not work as intended
• I have read https://github.com/signalapp/Signal-Android/wiki/Submitting-useful-bug-reports
• This isn't a feature request or a discussion topic

---

Bug description

Attempting to forward a message thread that has a message retrieval error results in a fatal crash.

Steps to reproduce

• On error downloading mms message (not sure how to reproduce)
• Hold the message to get options, tap forward icon

Actual result: Signal crashes
Expected result: Error toast or forward is disabled for message errors.

Screenshots

Device info

Device: Samsung Galaxy
Android version: 6.0.1
Signal version: 4.21.6

Link to debug log

https://debuglogs.org/739f42a284b0dca41b8b36e9d713fbc388b55701629c3b46efe26d1f46ac078c

[cascheberg]

From your debuglog:

FATAL EXCEPTION: main
E AndroidRuntime: Process: org.thoughtcrime.securesms, PID: 21355
E AndroidRuntime: java.lang.ClassCastException: org.thoughtcrime.securesms.database.model.NotificationMmsMessageRecord cannot be cast to org.thoughtcrime.securesms.database.model.MediaMmsMessageRecord
E AndroidRuntime: at org.thoughtcrime.securesms.ConversationFragment.handleForwardMessage(ConversationFragment.java:402)

Looks like this commit fixed a similar issue: fd6d947
There are some more similar casts in other places, but I can't really tell which of them are safe.

[greyson-signal]

Thank you for the report! Merged into 4.23. c7066c0