Skip to content

Show large images in correct orientation#11881

Closed
artnc wants to merge 1 commit intosignalapp:masterfrom
artnc:master
Closed

Show large images in correct orientation#11881
artnc wants to merge 1 commit intosignalapp:masterfrom
artnc:master

Conversation

@artnc
Copy link
Contributor

@artnc artnc commented Jan 2, 2022

First time contributor checklist

Contributor checklist

  • Virtual device, Android 9.0
  • My contribution is fully baked and ready to be merged as is
  • I ensure that all the open issues my contribution fixes are mentioned in the commit message of my first commit using the Fixes #1234 syntax

Description

This PR fixes #11614 (and #11732) by reading the image's Exif data and manually setting its display orientation ourselves as opposed to relying on the SubsamplingScaleImageView.ORIENTATION_USE_EXIF flag, which @greyson-signal has said is unreliable.

Before After
Screenshot_1641092764 Screenshot_1641092833

The thumbnail view remains unchanged and correct:

Screenshot_1641092759

Test image

signal-2022-01-01-220419

@greyson-signal
Copy link
Contributor

Thank you! We'll get this into the next release.

@stale
Copy link

stale bot commented Mar 4, 2022

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the wontfix label Mar 4, 2022
@artnc
Copy link
Contributor Author

artnc commented Mar 7, 2022

Fixed in 49a1a4a

@artnc artnc closed this Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Large images displayed in incorrect orientation

2 participants