Show large images in correct orientation#11881
Closed
artnc wants to merge 1 commit intosignalapp:masterfrom
Closed
Show large images in correct orientation#11881artnc wants to merge 1 commit intosignalapp:masterfrom
artnc wants to merge 1 commit intosignalapp:masterfrom
Conversation
Contributor
|
Thank you! We'll get this into the next release. |
|
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
Contributor
Author
|
Fixed in 49a1a4a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First time contributor checklist
Contributor checklist
Fixes #1234syntaxDescription
This PR fixes #11614 (and #11732) by reading the image's Exif data and manually setting its display orientation ourselves as opposed to relying on the
SubsamplingScaleImageView.ORIENTATION_USE_EXIFflag, which @greyson-signal has said is unreliable.The thumbnail view remains unchanged and correct:
Test image