-
-
Notifications
You must be signed in to change notification settings - Fork 6.6k
Improve group update descriptions #5416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve group update descriptions #5416
Conversation
d79fa6c to
80c4c5b
Compare
80c4c5b to
c2b2290
Compare
c2b2290 to
38fe480
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This method is designed to be idempotent, and is called from several places. Instead of making it dependent on some external functionality (since it can now return an empty string), it seems both safer and cleaner to consider making your changes in this method.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated this PR in a followup commit. There is currently only that one caller, and it now passes the sender as a method parameter. Please let me know if you have suggestions other than these two approaches.
38fe480 to
5496ba3
Compare
5496ba3 to
c93b5b3
Compare
c93b5b3 to
a00a9a8
Compare
|
Do you think it would be possible to differentiate between creating a group and editing/updating it? A message saying "You've updated the group" as confirmation for creating one feels a bit strange to me. |
|
in 3.32.0 |
Contributor checklist
FREEBIEin my commit messageDescription
Before:

After:

// FREEBIE
Outgoing group update descriptions could be more precise if they didn't contain unchanged group title, members and avatar.