Skip to content

Conversation

@cascheberg
Copy link
Contributor

Contributor checklist

  • I am following the Code Style Guidelines
  • I have tested my contribution
  • My contribution is fully baked and ready to be merged as is
  • I have made the choice whether I want the BitHub reward or not by omitting or adding the word FREEBIE in my commit message

Description

Before:
group_update_before

After:
group_update_after

// FREEBIE

Outgoing group update descriptions could be more precise if they didn't contain unchanged group title, members and avatar.

@cascheberg cascheberg force-pushed the fix_group_update_description branch from d79fa6c to 80c4c5b Compare April 5, 2016 16:45
@cascheberg cascheberg force-pushed the fix_group_update_description branch from 80c4c5b to c2b2290 Compare July 19, 2016 19:40
@cascheberg cascheberg force-pushed the fix_group_update_description branch from c2b2290 to 38fe480 Compare September 3, 2016 05:56
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This method is designed to be idempotent, and is called from several places. Instead of making it dependent on some external functionality (since it can now return an empty string), it seems both safer and cleaner to consider making your changes in this method.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated this PR in a followup commit. There is currently only that one caller, and it now passes the sender as a method parameter. Please let me know if you have suggestions other than these two approaches.

@cascheberg cascheberg force-pushed the fix_group_update_description branch from 38fe480 to 5496ba3 Compare November 21, 2016 19:31
@cascheberg cascheberg force-pushed the fix_group_update_description branch from 5496ba3 to c93b5b3 Compare January 13, 2017 18:53
@RiseT
Copy link
Contributor

RiseT commented Mar 9, 2017

Do you think it would be possible to differentiate between creating a group and editing/updating it? A message saying "You've updated the group" as confirmation for creating one feels a bit strange to me.

moxie0 pushed a commit that referenced this pull request Mar 14, 2017
@moxie0
Copy link
Contributor

moxie0 commented Mar 14, 2017

in 3.32.0

@moxie0 moxie0 closed this Mar 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants