Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Add action indicator when resending a message. #6347
First time contributor checklist
When sending of message fails, user can go into details of that message and click RESEND button to retry. As issue #6307 mentions, after clicking that button nothing really indicates on the screen that message is being resent in the background.
This pull request hides the RESEND button when resending asynchronous task is started, as well as hides the "error_description" TextView and replaces it with the "action_description" TextView which says "Resending...". That should provide a nice indicator that clicking the RESEND button actually had an effect.
@mammuth Thanks, I've tested the case when sending fails multiple times as well as the case when it fails and then succeeds and it seems to work fine.
There is no explicit code to make the resend-button visible again and hide the actionDescription, but I believe that every time resending is finished the whole
I'm not an android developer by trade so I'm not 100% sure that my understanding is correct, but it looks like
Please correct me if I'm wrong :-)
The screenshots from both options are below so you can judge it yourself (I'm sorry they are "reddish", I forgot to turn Twilight off).
And when translations are longer (used polish strings, I was too lazy to change language of the whole app)