New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inform user that message is too long to be displayed. #6692

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@greenjoe
Copy link
Contributor

greenjoe commented May 30, 2017

Contributor checklist

  • LG Nexus 5x, Android 7.1.2
  • My contribution is fully baked and ready to be merged as is
  • I ensure that all the open issues my contribution fixes are mentioned in the commit message of my first commit using the Fixes #1234 syntax
  • I have made the choice whether I want the BitHub reward or not by omitting or adding the word FREEBIE in the commit message of my first commit

Description

Currently text messages are silently cut when they are longer than 2000 characters (as mentioned in issue #5146). It can be really annoying as users may not even notice that part of message is not shown if the message is not cut half-sentence. I had this problem multiple times when my contact copied a longer text to me using Signal Desktop and I tried to read it on Android.

Resolving the issue properly probably requires a lot of work (like adding a way to display full message body or splitting large messages into smaller parts) and I believe it will take some time, especially considering that the issue mentioned is already over a year old. In the meantime I think it would be fair to inform users that part of message is not displayed so that they can resolve it with their contacts somehow (like using another communication channel or splitting the message manually).

@@ -421,6 +421,7 @@
<string name="MessageRecord_you_set_disappearing_message_time_to_s">You set disappearing message time to %1$s.</string>
<string name="MessageRecord_s_set_disappearing_message_time_to_s">%1$s set disappearing message time to %2$s.</string>
<string name="MessageRecord_your_safety_number_with_s_has_changed">Your safety number with %s has changed.</string>
<string name="MessageRecord_message_too_long">Message is too long to be displayed.</string>

This comment has been minimized.

@McLoo

McLoo May 31, 2017

Contributor

Message is too long to be displayed completely.

maybe followed by sth. like:
n characters got truncated.
(which surely confuses ppl if the message length was MAX_DISPLAY_LENGTH+1 :D )

This comment has been minimized.

@greenjoe

greenjoe Jun 13, 2017

Contributor

Added "completely". I think that displaying number of truncated characters would just clutter the view.

@greenjoe greenjoe force-pushed the greenjoe:message_too_long_info branch from 80e2ee9 to 5c3ec7f Jun 13, 2017

@greenjoe

This comment has been minimized.

Copy link
Contributor

greenjoe commented Jun 13, 2017

Rebased onto master and resolved conflicts.
When testing I noticed that Signal-Desktop now displays a nice warning "Android clients will only receive the first 2000 characters of this message" - wonderful! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment