Autofocus conversation text input when switching back to application #2885
Conversation
|
I don't think this is going to work. For example, open the media gallery, switch away from a conversation, then switch back with this change. |
|
I guess this would some real-world testing running the client connected to production network.. |
…(unless a panel or audio recording is open)
|
I added checks to see if a panel is open, or if the audio recorder view is open, to avoid taking the focus in those situations. |
|
If this is not a good approach, another option would be to do it like WhatsApp (if you start typing without focus, it automatically focuses the text input) or Telegram (clicking history view doesn't take focus away from text input). |
|
Really, what I'm looking for is testing. Contributing.md should help you get a staging app up and running, and then you can do exhaustive testing on this. I don't think we can merge this until you've done testing and summarized your findings here. |
|
Related: #1416 |
|
Apologies for not having time to work on this. I still suffer from this every day while using Signal Desktop, as it randomly loses focus of the text input field. |
|
Closing stale pull requests. |
First time contributor checklist:
Contributor checklist:
developmentbranchDescription
Very simple fix to automatically focus the text input field of an open conversation when switching back to the Signal application. This prevents text being "lost" when you switch to the app and immediately start typing, without first manually clicking the input field to give it focus.