Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Note to Self #3141

Closed
wants to merge 1 commit into
base: development
from

Conversation

Projects
None yet
3 participants
@Xashyar
Copy link
Contributor

Xashyar commented Feb 14, 2019

First time contributor checklist:

Contributor checklist:

Description

34px makes the "Note to Self" string Appear as "Note to S..."

max-width: calc(100% - 34px);

image

max-width: calc(100% - 32px);

image

@scottnonnenberg-signal

This comment has been minimized.

Copy link
Contributor

scottnonnenberg-signal commented Feb 14, 2019

Can you talk about where you see this? What platforms (and potentially locales) where this is happening?

@rmoore

This comment has been minimized.

Copy link

rmoore commented Feb 21, 2019

Not sure if I should open a separate bug report for this or what, but I just got the 1.22.0 release and am experiencing the same truncation of "Note to S..." in the top-bar of the Note to Self conversation:

note_to_s

I'm getting this on a Pixelbook running Signal Desktop on the "Run Linux on your Chromebook" feature of recent-ish ChromeOS releases.

@scottnonnenberg-signal

This comment has been minimized.

Copy link
Contributor

scottnonnenberg-signal commented Feb 21, 2019

Let's definitely get a bug opened for this. I don't think this fix is the right one, and moreover we don't fully understand where or when it is happening. The big question is: does it happen in any other conversation header with a contact, where similar layout techniques are being used?

@rmoore rmoore referenced this pull request Feb 22, 2019

Open

Conversation header text is sometimes truncated #3168

1 of 1 task complete
@rmoore

This comment has been minimized.

Copy link

rmoore commented Feb 22, 2019

Sorry for the delay there, was busy. Opened #3168 to track it. Let me know if you need some info there.

@scottnonnenberg-signal

This comment has been minimized.

Copy link
Contributor

scottnonnenberg-signal commented Feb 22, 2019

Closing this officially. We need more information what configurations this happens in. I'm on MacOS, and I don't see it. I just tested on Windows, don't see it there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.