Fix for #241: Updating Timestamps #382
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes the problem, that timestamps are not refreshed. Messages always stated "a few seconds ago", even time was passing. * Included jquery-timeago (patched version) and updates components.js (other dependencies where not updated) * Change template to HTML5 <time> tag * Include the ISO timestamp * If a message is older then 24 hours, the full timestamp is displayed and no refreshing is initialized to save resources. Also I believe, that in this case the full timestamp is easier to conceive.
| @@ -77,7 +77,7 @@ | |||
| <div class='attachments'></div> | |||
| <p class="content">{{ message }}</p> | |||
| <div class='meta'> | |||
| <span class='timestamp'>{{ timestamp }}</span> | |||
| <time datetime="{{ iso_timestamp }}">{{ timestamp }}</time> | |||
There was a problem hiding this comment.
loss of .timestamp class breaks styling
|
Fixed the class ... What do you think about the general approach? Unfortunately there are merge conflicts with the recent master .. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the problem, that timestamps are not refreshed.
Messages always stated "a few seconds ago", even time was passing.
(other dependencies where not updated)
and no refreshing is initialized to save resources.
Also I believe, that in this case the full timestamp is easier to conceive.