Add guard: stop attachment during audio record #5255
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #5205 Sends a toast when the user clicks the "+" attach file during an audio recording. The file chooser doesn't appear anymore. The toast may overlap the existing toast that is sent at the beginning of the audio recording.
|
You don't need to care about translations, they are handled separately via https://www.transifex.com/projects/p/signal-desktop. |
| @@ -337,6 +337,9 @@ Whisper.AlreadyRequestedToJoinToast = Whisper.ToastView.extend({ | |||
| template: () => window.i18n('GroupV2--join--already-awaiting-approval'), | |||
| }); | |||
|
|
|||
| Whisper.UnableToAttachFileWhileRecording = Whisper.ToastView.extend({ | |||
| template: () => window.i18n('unableToAttachFileWhileRecording'), | |||
|
|
|||
There was a problem hiding this comment.
Looks like this is broken.
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5205
Fixes an issue where an audio recording would stop and be lost if a file was attached during the recording.
A toast is sent instead and the audio recording keeps recording.
First time contributor checklist:
Contributor checklist:
developmentbranchyarn readyrun passes successfully (more about tests here)Description
Please write a summary of your test approach: