Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

callsignVhf missing for 129794 and 129810 #237

Closed
wellenvogel opened this issue Mar 23, 2022 · 5 comments · Fixed by #238
Closed

callsignVhf missing for 129794 and 129810 #237

wellenvogel opened this issue Mar 23, 2022 · 5 comments · Fixed by #238

Comments

@wellenvogel
Copy link
Contributor

The decoder should set communication/callsignVhf from the mentioned PGNs. Otherwise AIS data from N2K will miss this information (although available in the bus data).

wellenvogel pushed a commit to wellenvogel/n2k-signalk that referenced this issue Apr 3, 2022
@pa1pdr
Copy link

pa1pdr commented Aug 24, 2024

Can I ask for merging this? I also need the callsignVHF to be populated in the SK delta's

@sbender9
Copy link
Member

please check the PR, I added a comment

@wellenvogel
Copy link
Contributor Author

Unfortunately I currently do not have any idea about the signalK testing - so it's hard for me to add those tests.

@pa1pdr
Copy link

pa1pdr commented Aug 27, 2024

Andreas, if you go into the test directory, you'll find e.g. the 129794_ais_class_a_static_data.js file and add somewhere at line 81 the line

tree.should.have.nested.property(
      'communication.callsignVhf',
      '3FJJ4'
    )

The 3FJJ4 is in the testdata in line 46.
Since the expected IMO number in line 69 is wrong, the test will fail anyway, but that is not your issue..

Do something similar for 129810 and you're done. Thanks for your help!

@wellenvogel
Copy link
Contributor Author

Thanks. Added the test for 129794. But currently there is no test for 129810 at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants