Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge with jDrupal? #23

Closed
kentr opened this issue Mar 1, 2016 · 5 comments
Closed

Merge with jDrupal? #23

kentr opened this issue Mar 1, 2016 · 5 comments

Comments

@kentr
Copy link
Collaborator

kentr commented Mar 1, 2016

I've been looking at jDrupal 8.x-1.x, which appears much more full-featured & functional for interaction with D8 REST, and I've gotten a basic bridge working to turn jDrupal into an AngularJS service.

Am I correct in understanding that jDrupal has more support for D8 REST than angular-drupal does? Would you consider merging them (like, making angular-drupal a wrapper around jDrupal)? I would be glad to contribute what I've done so far on that front.

@signalpoint
Copy link
Owner

@kentr yes this would be great. jDrupal is a dependency for angular-drupal 8, so it does make sense to merge them, and just build a little Angular layer on top of jDrupal 8. Thank you for your interest on ideas on this!

@kentr
Copy link
Collaborator Author

kentr commented Mar 2, 2016

Great. Initial work is here. Not tested enough for a pr yet.

I don't see jDrupal in bower.json as a dependency. How is the dependency defined?

@signalpoint
Copy link
Owner

@kentr Oh, it looks like it is only a dependency in my head, I guess I never actually wrote it down!

I was thinking of making the angular_drupal module for Drupal 8 dependent on the jdrupal module for Drupal 8.

What do you think? Feel free to add jdrupal to bower.json as a dependency, I haven't gotten that far yet.

@kentr
Copy link
Collaborator Author

kentr commented Mar 2, 2016

Ok, I'll do that.

@kentr
Copy link
Collaborator Author

kentr commented May 9, 2016

First steps on this are done.

@kentr kentr closed this as completed May 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants