-
Notifications
You must be signed in to change notification settings - Fork 14
Add status callback fields to CXML and SWML Scripts endpoints #387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Devon-White
merged 7 commits into
Devon/fabric-typespec
from
diego/15477/document-status-callback-url-on-typespec
Jul 17, 2025
Merged
Add status callback fields to CXML and SWML Scripts endpoints #387
Devon-White
merged 7 commits into
Devon/fabric-typespec
from
diego/15477/document-status-callback-url-on-typespec
Jul 17, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yarn run v1.22.22 OpenAPI Specification AnalysisChanges are compared to the
Done in 160.30s. |
…-callback-url-on-typespec
Devon-White
requested changes
Jul 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just made a few changes :)
specs/signalwire-rest/fabric-api/cxml-scripts/models/requests.tsp
Outdated
Show resolved
Hide resolved
specs/signalwire-rest/fabric-api/cxml-scripts/models/requests.tsp
Outdated
Show resolved
Hide resolved
specs/signalwire-rest/fabric-api/cxml-scripts/models/requests.tsp
Outdated
Show resolved
Hide resolved
specs/signalwire-rest/fabric-api/swml-scripts/models/requests.tsp
Outdated
Show resolved
Hide resolved
specs/signalwire-rest/fabric-api/swml-scripts/models/requests.tsp
Outdated
Show resolved
Hide resolved
Devon-White
approved these changes
Jul 17, 2025
Devon-White
added a commit
that referenced
this pull request
Jul 17, 2025
* Initial push * Convert all Fabric api spec to TypeSpec * add newline * Update main.tsp * Update responses.tsp * Update main.tsp * Update core.tsp * Update errors.tsp * Update requests.tsp * Push audit edits (in-progress) * Update specs/signalwire-rest/fabric-api/dialogflow-agents/addresses/models/core.tsp Co-authored-by: Cassie <58792902+cassieemb@users.noreply.github.com> * Add enums for Ciphers, Codecs, and Encryption in globally_shared specs - Introduced Ciphers enum with various AES cipher options. - Added Codecs enum for audio and video codecs including PCMU, PCMA, G722, G729, OPUS, VP8, and H264. - Created Encryption enum to define encryption requirements: Required, Optional, and Default. * edits * edits * edits * edits * edits * Add global constants and SIP endpoint enums - Introduced a new constant for the server URL in const.tsp. - Added an enumeration for CallHandlerType in enums.tsp, defining various call handling options. - Add pagination response for many list endpoints * Refactor API tags and documentation for SignalWire Fabric API - Introduced a new tags.tsp file to centralize tag definitions and metadata for various API endpoints. - Updated multiple API specifications to replace hardcoded tag strings with constants from the new tags.tsp file. - Enhanced OpenAPI documentation by adding summaries and descriptions for various endpoints, improving clarity and usability. - Added external documentation links for each tag to facilitate developer access to relevant resources. - Ensured consistent naming conventions across all API tags to improve readability and maintainability. * Fix bad summary * Conference Room edits * add missing fps property to conference rooms * Add redirects * Add status callback fields to CXML and SWML Scripts endpoints (#387) * Add status callback fields to CXML and SWML Scripts endpoints * Update core.tsp * Update specs/signalwire-rest/fabric-api/cxml-scripts/models/requests.tsp * Update specs/signalwire-rest/fabric-api/cxml-scripts/models/requests.tsp * Update specs/signalwire-rest/fabric-api/swml-scripts/models/requests.tsp * Update specs/signalwire-rest/fabric-api/swml-scripts/models/requests.tsp --------- Co-authored-by: Devon <86693904+Devon-White@users.noreply.github.com> * recompile spec after additions * Update specs/signalwire-rest/fabric-api/cxml-applications/models/requests.tsp Co-authored-by: Cassie <58792902+cassieemb@users.noreply.github.com> * Update specs/signalwire-rest/fabric-api/cxml-applications/models/core.tsp Co-authored-by: Cassie <58792902+cassieemb@users.noreply.github.com> * Update specs/signalwire-rest/fabric-api/cxml-applications/models/core.tsp Co-authored-by: Cassie <58792902+cassieemb@users.noreply.github.com> * Update specs/signalwire-rest/fabric-api/cxml-applications/models/requests.tsp Co-authored-by: Cassie <58792902+cassieemb@users.noreply.github.com> * Update specs/signalwire-rest/fabric-api/cxml-applications/models/requests.tsp Co-authored-by: Cassie <58792902+cassieemb@users.noreply.github.com> * Update specs/signalwire-rest/fabric-api/cxml-applications/models/responses.tsp Co-authored-by: Cassie <58792902+cassieemb@users.noreply.github.com> * Update specs/signalwire-rest/fabric-api/cxml-applications/models/responses.tsp Co-authored-by: Cassie <58792902+cassieemb@users.noreply.github.com> * Ran TypeSpec formatter * Ran formatter, and recompiled spec --------- Co-authored-by: Cassie <58792902+cassieemb@users.noreply.github.com> Co-authored-by: diego-signalwire <diego.oliveira@signalwire.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
REST API Update Pull Request
Related Issue
https://github.com/signalwire/cloud-product/issues/15477
https://github.com/signalwire/cloud-product/issues/15251
Description
This PR adds status callback functionality to CXML Scripts and SWML Scripts endpoints in the Fabric API specification. The changes expose the ability to set status callback fields that were previously only
available through the Fabric UI.
CXML Scripts Changes:
SWML Scripts Changes:
Type of Change
Checklist:
team/developer-experience
label in the PR.Additional Notes
Add any other context about the pull request here.