[Merged by Bors] - Ensure .git is copied into docker #1462
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulhauner
added
work-in-progress
michaelsproul
changed the title
michaelsproul
approved these changes
Aug 5, 2020
Member
michaelsproul
left a comment
michaelsproul
left a comment
There was a problem hiding this comment.
Tested and working
bors r+
michaelsproul
added
ready-for-merge
bors bot
pushed a commit
that referenced
this pull request
Aug 5, 2020
## Issue Addressed - Resolves #1461 ## Proposed Changes Copy the `.git` directory across when building docker so we can get commit information. Unfortunately this means duplicating you `.git` directory which might be quite large (mine is >100mb). Notably this directory isn't contained in the final image, just the intermediate builder image. ## Additional Info NA
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Proposed Changes
Copy the
.gitdirectory across when building docker so we can get commit information.Unfortunately this means duplicating you
.gitdirectory which might be quite large (mine is >100mb). Notably this directory isn't contained in the final image, just the intermediate builder image.Additional Info
NA