[Merged by Bors] - Downgrade ADX check to a warning #1846
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelsproul
added
ready-for-review
paulhauner
approved these changes
Nov 2, 2020
Member
paulhauner
left a comment
paulhauner
left a comment
There was a problem hiding this comment.
Looks good, modulo one comment that you can choose to address if you like.
|
|
||
| ## Troubleshooting | ||
|
|
||
| If you get a SIGILL (exit code 132), then your CPU is incompatible with the optimized build |
Member
There was a problem hiding this comment.
I guess this concept also applies to "Build from Source" as well. I notice it doesn't have any info about portability.
I'll leave it up to you to decide if you want to address that here.
Member
Author
There was a problem hiding this comment.
It shouldn't apply to source builds unless the user forces ADX on by bypassing the makefile, or moves a binary from an ADX machine to a non-ADX one. For now I'm in favour of merging ASAP, and we can add a note later if people run into it
Member
Author
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Nov 2, 2020
## Issue Addressed Closes #1842 ## Proposed Changes Due to the lies told to us by VPS providers about what CPU features they support, we are forced to check for the availability of CPU features like ADX by just _running code and seeing if it crashes_. The prominent warning should hopefully help users who have truly incompatible CPUs work out what is going on, while not burdening users of cheap VPSs.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
bors bot
pushed a commit
that referenced
this pull request
Nov 2, 2020
## Issue Addressed NA ## Proposed Changes - Update versions - Run `cargo update` ## Additional Info - Blocked on #1846
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Closes #1842
Proposed Changes
Due to the lies told to us by VPS providers about what CPU features they support, we are forced to check for the availability of CPU features like ADX by just running code and seeing if it crashes. The prominent warning should hopefully help users who have truly incompatible CPUs work out what is going on, while not burdening users of cheap VPSs.