[Merged by Bors] - [Remote signer] Fold signer into Lighthouse repository #1852
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
ghost
changed the title
ghost
mentioned this pull request
paulhauner
reviewed
Nov 6, 2020
paulhauner
reviewed
Nov 6, 2020
paulhauner
approved these changes
Nov 6, 2020
Member
paulhauner
left a comment
paulhauner
left a comment
There was a problem hiding this comment.
Awesome, remote signer is go!
Feel free to bors r+ when you see fit :)
Author
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Nov 6, 2020
The remote signer relies on the `types` and `crypto/bls` crates from Lighthouse. Moreover, a number of tests of the remote signer consumption of LH leverages this very signer, making any important update a potential dependency nightmare. Co-authored-by: Paul Hauner <paul@paulhauner.com>
|
Build failed: |
Author
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Nov 6, 2020
The remote signer relies on the `types` and `crypto/bls` crates from Lighthouse. Moreover, a number of tests of the remote signer consumption of LH leverages this very signer, making any important update a potential dependency nightmare. Co-authored-by: Paul Hauner <paul@paulhauner.com>
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
paulhauner
added a commit
that referenced
this pull request
Nov 9, 2020
The remote signer relies on the `types` and `crypto/bls` crates from Lighthouse. Moreover, a number of tests of the remote signer consumption of LH leverages this very signer, making any important update a potential dependency nightmare. Co-authored-by: Paul Hauner <paul@paulhauner.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The remote signer relies on the
typesandcrypto/blscrates from Lighthouse. Moreover, a number of tests of the remote signer consumption of LH leverages this very signer, making any important update a potential dependency nightmare.