[Merged by Bors] - handle peer state transitions on gossipsub score changes + refactoring #1892
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AgeManning
requested changes
Nov 13, 2020
| &mut self.events, | ||
| &self.log, | ||
| ); | ||
| if previous_state == info.score_state() { |
Contributor
Author
There was a problem hiding this comment.
No this should really be an ==. It was the else branch in the original code. Basically we log already a line inside handle_score_transitions if the state changed. This line here is to log that the score changed if the state didn't change.
Member
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Nov 13, 2020
#1892) ## Issue Addressed NA ## Proposed Changes Correctly handles peer state transitions on gossipsub changes + refactors handling of peer state transitions into one function used for lighthouse score changes and gossipsub score changes. Co-authored-by: Age Manning <Age@AgeManning.com>
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
NA
Proposed Changes
Correctly handles peer state transitions on gossipsub changes + refactors handling of peer state transitions into one function used for lighthouse score changes and gossipsub score changes.