Skip to content

[Merged by Bors] - Update logs + do not downscore peers if WE time out #1901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
divagant-martian wants to merge 2 commits into from
Closed

[Merged by Bors] - Update logs + do not downscore peers if WE time out #1901

divagant-martian wants to merge 2 commits into from

Conversation

@divagant-martian
Copy link
Contributor

@divagant-martian divagant-martian commented Nov 14, 2020 •
edited
Loading

Issue Addressed

  • RPC Errors were being logged twice: first in the peer manager and then again in the router, so leave just the peer manager's one
  • The "reduce peer count" warn message gets thrown to the user for every missed chunk, so instead print it when the request times out and also do not include there info that is not relevant to the user
  • The processor didn't have the service tag so add it
  • Impl KV for status message
  • Do not downscore peers if we are the ones that timed out

Other small improvements

@divagant-martian
Update logs
21f5f65 
Impl KV for StatusMessage

Set the service for the router
@divagant-martian divagant-martian changed the title Update logs Update logs + do not downscore peers if WE time out Nov 15, 2020
AgeManning
AgeManning approved these changes Nov 16, 2020
View reviewed changes
Copy link
Member

@AgeManning AgeManning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AgeManning
Copy link
Member

AgeManning commented Nov 16, 2020

bors r+

bors bot pushed a commit that referenced this pull request Nov 16, 2020
@divagant-martian
Update logs + do not downscore peers if WE time out (#1901)
eb56140 
## Issue Addressed

- RPC Errors were being logged twice: first in the peer manager and then again in the router, so leave just the peer manager's one 
- The "reduce peer count" warn message gets thrown to the user for every missed chunk, so instead print it when the request times out and also do not include there info that is not relevant to the user
- The processor didn't have the service tag so add it
- Impl `KV` for status message
- Do not downscore peers if we are the ones that timed out

Other small improvements
@bors
Copy link

bors bot commented Nov 16, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title Update logs + do not downscore peers if WE time out [Merged by Bors] - Update logs + do not downscore peers if WE time out Nov 16, 2020
@bors bors bot closed this Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AgeManning AgeManning AgeManning approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@divagant-martian @AgeManning