Skip to content

Conversation

@paulhauner
Copy link
Member

Issue Addressed

Proposed Changes

Additional Info

NA

@paulhauner paulhauner added ready-for-review The code is ready for review low-hanging-fruit Easy to resolve, get it before someone else does! labels Nov 21, 2020
Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michaelsproul michaelsproul added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Nov 21, 2020
@paulhauner
Copy link
Member Author

bors r+

bors bot pushed a commit that referenced this pull request Nov 22, 2020
## Issue Addressed

- Resolves #1945

## Proposed Changes

- As per #1945, fix a log message from the metrics server that was falsely claiming to be from the api server.
- Ensure successful api request logs are published to debug, not trace. This is something I've wanted to do for a while.

## Additional Info

NA
@bors
Copy link

bors bot commented Nov 22, 2020

@bors bors bot changed the title Fix metrics http server error messages [Merged by Bors] - Fix metrics http server error messages Nov 22, 2020
@bors bors bot closed this Nov 22, 2020
@paulhauner paulhauner deleted the fix-http-error branch March 17, 2021 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

low-hanging-fruit Easy to resolve, get it before someone else does! ready-for-merge This PR is ready to merge.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Lighthouse Incorrectly Reports That HTTP API Address Is in Use When Metrics Port Is in Use

3 participants