[Merged by Bors] - Update ENR construction and mainnet bootnodes #1968
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Nov 25, 2020
## Issue Addressed Boot nodes were being successfully created and publishing valid ENRs however the `eth2` field was not being saved to disk leading to a discrepancy between published ENR and disk ENR. If the `eth2` field is known, it is now constructed in the initial ENR and saved to disk. Previous mainnet bootnodes did not contain the `eth2` field and these have also been updated.
|
Pull request successfully merged into unstable. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Boot nodes were being successfully created and publishing valid ENRs however the
eth2field was not being saved to disk leading to a discrepancy between published ENR and disk ENR.If the
eth2field is known, it is now constructed in the initial ENR and saved to disk.Previous mainnet bootnodes did not contain the
eth2field and these have also been updated.