[Merged by Bors] - Sync metrics #1975
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AgeManning
approved these changes
Nov 25, 2020
Member
AgeManning
left a comment
AgeManning
left a comment
There was a problem hiding this comment.
This looks good to me.
Would be nice to have an accompanying PR in lighthouse-metrics with it.
As this is still in draft, I'm going to be selfish and try and merge tokio-0.3 in first, as there will be conflicts :p
divagant-martian
force-pushed
the
peer-sync-type-metrics
branch
from
0967bca to
0da0af1
Compare
Contributor
Author
|
accompanying PR in lighthouse-metrics: sigp/lighthouse-metrics#11 |
Member
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Nov 26, 2020
## Issue Addressed - Add metrics to keep track of peer counts by sync type - Add metric to keep track of the number of syncing chains in range ## Proposed Changes Plugin to the network metrics update interval and update too the counts for peers wrt to their sync status with us ## Additional Info For the peer counts - By the way it is implemented the numbers won't always match to the total peer count in the `libp2p` metric. - Updating the gauge with every change is messy because it requires to be updated on connection (in the `eth2_libp2p` crate, while metrics are defined in the `network` crate) on Goodbye sent (for an `IrrelevantPeer`) either in the `beacon_processor` or the `peer_manager`, and on disconnection. Since this is not a critical metric I think counting once every second is enough. If you think more accuracy is needed we can do it too, but it would be harder to maintain) ATM those look like this 
|
Pull request successfully merged into unstable. Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Proposed Changes
Plugin to the network metrics update interval and update too the counts for peers wrt to their sync status with us
Additional Info
For the peer counts
libp2pmetric.eth2_libp2pcrate, while metrics are defined in thenetworkcrate) on Goodbye sent (for anIrrelevantPeer) either in thebeacon_processoror thepeer_manager, and on disconnection. Since this is not a critical metric I think counting once every second is enough. If you think more accuracy is needed we can do it too, but it would be harder to maintain)ATM those look like this
