[Merged by Bors] - Add docs for /lighthouse/validators/keystore api
#2071
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
paulhauner
added
ready-for-merge
bors bot
pushed a commit
that referenced
this pull request
Dec 21, 2020
## Issue Addressed Resolves #2061 Resolves #2066 ## Proposed Changes Document the `/lighthouse/validators/keystore` validator api method. The newly generated/imported keystore is always added to the key cache from this function call https://github.com/sigp/lighthouse/blob/65dcdc361b0c91dabe53c886e32aa7952251be68/validator_client/src/validator_store.rs#L105-L109 which eventually invokes `KeyCache::add` here if enabled https://github.com/sigp/lighthouse/blob/65dcdc361b0c91dabe53c886e32aa7952251be68/validator_client/src/initialized_validators.rs#L192
|
Pull request successfully merged into unstable. Build succeeded: |
bors
bot
changed the title
/lighthouse/validators/keystore api/lighthouse/validators/keystore api
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Resolves #2061
Resolves #2066
Proposed Changes
Document the
/lighthouse/validators/keystorevalidator api method.The newly generated/imported keystore is always added to the key cache from this function call
lighthouse/validator_client/src/validator_store.rs
Lines 105 to 109 in 65dcdc3
which eventually invokes
KeyCache::addhere if enabledlighthouse/validator_client/src/initialized_validators.rs
Line 192 in 65dcdc3