[Merged by Bors] - Improve docker auto builds #2078
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…native source for installing emulation dependencies, hard-code the OS version this runs on
Member
|
I can't fault this, let's do it! bors r+ |
michaelsproul
approved these changes
Dec 11, 2020
bors bot
pushed a commit
that referenced
this pull request
Dec 11, 2020
## Issue Addressed N/A ## Proposed Changes - hardcode `ubuntu-18.04` -- I don't think this was causing us issues, but github actions is in the process of migrating `ubuntu-latest` from Ubuntu 18 -> 20.. so just in case - different source of emulation dependencies -> https://github.com/tonistiigi/binfmt - this one is explicitly referenced in the `buildx` github docs - install emulation dependencies and run `docker buildx` in the same `run` command - enable `buildx` with `DOCKER_CLI_EXPERIMENTAL: enabled` rather than re-building it ## Additional Info N/A Co-authored-by: realbigsean <seananderson33@gmail.com>
michaelsproul
added
ready-for-merge
paulhauner
approved these changes
Dec 11, 2020
|
Pull request successfully merged into unstable. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
N/A
Proposed Changes
ubuntu-18.04-- I don't think this was causing us issues, but github actions is in the process of migratingubuntu-latestfrom Ubuntu 18 -> 20.. so just in casebuildxgithub docsdocker buildxin the sameruncommandbuildxwithDOCKER_CLI_EXPERIMENTAL: enabledrather than re-building itAdditional Info
N/A