[Merged by Bors] - Update dependencies #2084
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AgeManning
approved these changes
Dec 13, 2020
Member
AgeManning
left a comment
AgeManning
left a comment
There was a problem hiding this comment.
We don't need our hyper here because 13.8 has done the necessary updates for us right?
Member
|
This closes #2086, so I'm going to merge it as highest prio. bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Dec 14, 2020
## Issue Addressed Partially addresses dependencies mentioned in issue #1712. ## Proposed Changes Updates dependencies (including an update avoiding a vulnerability) + add tokio compatibility to `remote_signer_test`
michaelsproul
added
ready-for-merge
|
Build failed: |
Member
|
DHT test failed bors retry |
bors bot
pushed a commit
that referenced
this pull request
Dec 14, 2020
## Issue Addressed Partially addresses dependencies mentioned in issue #1712. ## Proposed Changes Updates dependencies (including an update avoiding a vulnerability) + add tokio compatibility to `remote_signer_test`
|
Pull request successfully merged into unstable. Build succeeded: |
Contributor
Author
I don't think it was needed at all. The remote signer was the only crate using the fork and all the others already use upstream. At least it compiles and all tests run through, but this is the reason why I requested a review from @hermanjunge. Maybe he knows more why the fork dependency was needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Partially addresses dependencies mentioned in issue #1712.
Proposed Changes
Updates dependencies (including an update avoiding a vulnerability) + add tokio compatibility to
remote_signer_test