[Merged by Bors] - Revert "add caching to test suite (#2089)" #2098
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 80f47fc.
Member
|
Dang, nice try anyway bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Dec 16, 2020
## Issue Addressed N/A ## Proposed Changes I didn't realize the `PORTABLE` env variable is only picked up by `install` in the `Makefile` so we are still getting `SIGILL`s: https://github.com/sigp/lighthouse/runs/1565004525?check_suite_focus=true ## Additional Info Co-authored-by: realbigsean <seananderson33@gmail.com>
|
Pull request successfully merged into unstable. Build succeeded: |
bors
bot
changed the title
Member
|
I like the symmetry in the issue numbers, 2098 reverts 2089 😁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
N/A
Proposed Changes
I didn't realize the
PORTABLEenv variable is only picked up byinstallin theMakefileso we are still gettingSIGILLs:https://github.com/sigp/lighthouse/runs/1565004525?check_suite_focus=true
Additional Info