[Merged by Bors] - Eliminate uses of expect in ssz_snappy.rs
#2105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulhauner
approved these changes
Dec 21, 2020
Member
There was a problem hiding this comment.
Nice one, thank you @smoelius!
I believe this is a trivial change with no side-effects (apart from the benefits of staying safe within the type system).
bors r+
Member
|
bors r+ |
pawanjay176
approved these changes
Dec 21, 2020
Member
pawanjay176
left a comment
pawanjay176
left a comment
There was a problem hiding this comment.
LGTM. Thanks for the contribution @smoelius :)
bors bot
pushed a commit
that referenced
this pull request
Dec 21, 2020
## Issue Addressed None ## Proposed Changes Eliminate three uses of `expect` in `ssz_snappy.rs`. ## Additional Info None
|
Build failed: |
Member
|
Looks like |
Member
|
It's an instance of #2086, caused by trying to merge into the |
Member
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Dec 22, 2020
## Issue Addressed None ## Proposed Changes Eliminate three uses of `expect` in `ssz_snappy.rs`. ## Additional Info None
|
Pull request successfully merged into unstable. Build succeeded: |
bors
bot
changed the title
expect in ssz_snappy.rsexpect in ssz_snappy.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
None
Proposed Changes
Eliminate three uses of
expectinssz_snappy.rs.Additional Info
None