Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testnet compatible network upgrade #587

Merged
merged 58 commits into from Nov 27, 2019
Merged

Testnet compatible network upgrade #587

merged 58 commits into from Nov 27, 2019

Conversation

@AgeManning
Copy link
Member

AgeManning commented Oct 31, 2019

Overview

This PR will update Lighthouse to an interop version of the network specification, which we will use for public testnets. A further update is required for mainnet specifications.

This PR specifically modifies:

  • Req/Resp protocol to employ block streaming
  • Updates to the batch syncing logic to account for the underlying streaming mechanisms
  • Updates to gossipsub and discv5 (bug fixes and cross-client compatibility)
  • Misc re-factoring and code improvements

This resolves:
#525
#522
#502
#362

pawanjay176 and others added 29 commits Oct 3, 2019
TODO: Publish should be called just once
* Remove discovery tests
* Simplify gossipsub forward test topology
* Add helper functions for topology building
@paulhauner paulhauner added this to the Public Testnet milestone Nov 21, 2019
AgeManning added 2 commits Nov 22, 2019
AgeManning added 2 commits Nov 25, 2019
@AgeManning AgeManning requested a review from michaelsproul Nov 25, 2019
AgeManning added 4 commits Nov 26, 2019
@paulhauner paulhauner changed the title [WIP] Testnet compatible network upgrade Testnet compatible network upgrade Nov 26, 2019
Copy link
Member

paulhauner left a comment

Looking good. I've been through it, obvs haven't fully grokked it or the changes to the upstream libp2p libs.

Suggestions are primarily about making sure errors get to the logger. Still a bit anxious about the asserts and unreachables but I'll trust you on them.

beacon_node/eth2-libp2p/src/rpc/handler.rs Outdated Show resolved Hide resolved
beacon_node/eth2-libp2p/src/rpc/methods.rs Outdated Show resolved Hide resolved
beacon_node/network/Cargo.toml Show resolved Hide resolved
beacon_node/network/src/sync/manager.rs Outdated Show resolved Hide resolved
@paulhauner paulhauner merged commit 97aa8b7 into master Nov 27, 2019
6 checks passed
6 checks passed
cargo-fmt
Details
release-tests-ubuntu
Details
debug-tests-ubuntu
Details
ef-tests-ubuntu
Details
dockerfile-ubuntu
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.