Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Slashing Protection #588

Open
wants to merge 238 commits into
base: kill-grpc
from

Conversation

@pscott
Copy link
Contributor

pscott commented Oct 31, 2019

Issue Addressed

Closes #254
Closes #623

Proposed Changes

  • Add a slashing_protection crate in validator_client.

Additional info

Added some comments on github for things I'm unsure about.

Please see this hackmd note that explains the slashing protection implementation.

pscott and others added 30 commits Oct 24, 2019
…taandcustodybit
pawanjay176 and others added 4 commits Dec 12, 2019
* Clean up database metrics, add freezer DB size

* Address review comments
* Create backup instead of overwriting log files

* Clean variable names

* Return string instead of expect on SystemTimeError

* Cargo fmt after merge
@paulhauner paulhauner added this to the v0.2.0 milestone Dec 15, 2019
paulhauner and others added 19 commits Dec 16, 2019
* Add simulator to CI

* Install ganache before running sim
* add support for gzip

* Fix clippy warnings

* Fix additional clippy warnings and optimized get_deposits function

* Fix get_deposits function call

* Add simulator to CI

* Install ganache before running sim
* Add metrics for junk eth1 votes

* Add eth1 cache metrics
LGTM!
* Change verification strategy

* Update EF tests
* Add validator index to duties response

* Add `get_state` method to beacon chain

* Improve /beacon/validators endpoint

* Add validators/all and validators/active endpoints

* Start refactor of HTTP docs

* Document /beacon/heads endpoint

* Remove some unused API endpoints

* Improve API docs

* Add methods to get all validator duties

* Improve docs

* Remove dead links

* Make tables left-justified

* Add /consensus/vote_count endpoint

* Add /consensus/individual_votes endpoint

* Update formatting

* Tidy

* Add committees endpoint

* Strictly require 0x prefix for serde in BLS

* Update docs to have 0x prefix

* Fix failing tests

* Add unfinished code

* Improve testing, fix bugs

* Tidy, ensure all beacon endpoints smoke tested

* Fix pubkey cache error

* Address comments with docs
* Add functions to get deposit_count and deposit_root from deposit cache

* Fetch deposit root and deposit count from cache

* Fix bugs

* Add test

* Compare deposit_count between the caching and http eth1 blocks

* Revert "Compare deposit_count between the caching and http eth1 blocks"

This reverts commit e3d0325.

* Fetch deposit cache using binary search instead of linear search

* BlockCache waits till DepositCache is in sync

* Truncate required_blocks in block_cache upto latest_processed_block in deposit cache

* Clean up

* Handled getting deposit count before deploying deposit contract

* More cleanup

* Remove calls to http get deposit/count

* Fix block cache tests

* Minor changes

* Fix bootnode ports

* Address some of Paul's comments

* Optimize `get_deposit_root` by caching `DepositDataTree`

* Fix comments and minor changes

* Change eth1 default config parameters

* Use `Vec` instead of `HashMap` to store `deposit_roots`

* Minor renaming
* Add duplication prevention to gossipsub

* Clean up topic logs

* Add content addressed messages for gossip
* Add duplication prevention to gossipsub

* Clean up topic logs

* Add content addressed messages for gossip

* Support BlocksByRange step parameter
* Add duplication prevention to gossipsub

* Clean up topic logs

* Add content addressed messages for gossip

* Support BlocksByRange step parameter

* Add initial docs to syncing

* Adds documentation and simplify code in sync

* Remove unnecessary comment

* Fix fmt issue

* Add batch log to sync
* Replace gitter with Discord; fix typos; Specify the need to sign commits

* Add link to contributing document in lighthouse book
* Fix datadir bug; fix clippy warnings; update error message

* Cargo fmt

* Update error message
* Start adding optimization

* Add temp fix for protobuf issue

* Fix compile errors

* Fix protobuf import
* Set random port when zero-port option is set

* Remove logic allowing lighthouse to update its own ENR

* Discovery address is set to localhost by default

* Return error if discovery-addr isn't explicit
* Update gossipsub, adds anonymous source

* Remove temp protobuf fix
@paulhauner

This comment has been minimized.

Copy link
Member

paulhauner commented Jan 3, 2020

I'm still keen to get this merged, I'm just dealing with some more immediate sync-speed issues at the moment.

Please bear with me! :)

pscott added 3 commits Jan 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can’t perform that action at this time.