Repository navigation
address zizmor findings in CI definitions - #369
Merged
Merged
Conversation
Signed-off-by: Bob Callaway <bcallaway@google.com>
spencerschrock
left a comment
spencerschrock
left a comment
Contributor
There was a problem hiding this comment.
Thanks.
Bumping top-level permissions down and limiting credentials after checkout LGTM.
I don't think the addition of contents: write is needed, as our workflows have lacked this permission previously and work as desired.
Signed-off-by: Bob Callaway <bcallaway@google.com>
spencerschrock
approved these changes
Mar 20, 2025
spencerschrock
left a comment
spencerschrock
left a comment
Contributor
There was a problem hiding this comment.
Thanks. I'll need to wait for Mihai to click merge unless you're able to.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Release Note
Documentation