Start deprecation of --secret-name #215
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hectorj2f
changed the title
hectorj2f
force-pushed
the
deprecate_secret-name_flag
branch
2 times, most recently
from
d6a23f2 to
c01e54f
Compare
Signed-off-by: Hector Fernandez <hector@chainguard.dev>
hectorj2f
force-pushed
the
deprecate_secret-name_flag
branch
from
c01e54f to
50f707a
Compare
cpanato
approved these changes
Sep 6, 2022
vaikas
approved these changes
Sep 6, 2022
Collaborator
|
Thanks for doing this! As discussed offline the flag has been publicly documented as deprecated for awhile now: And it has been marked as deprecated there for > 3 months: So, removing this flag in the release after next SGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Hector Fernandez hector@chainguard.dev
Summary
The intention is to remove a flag that has been added with our first alpha version but it does not fit anymore in our declarative way of defining policies and authorities.
Following the Kubernetes deprecation policy for flags and beta versions, we will remove this flag in one release.
Release Note
Add a deprecation message to remove the -secret-name flag in the future.
Documentation