Skip to content

Start deprecation of --secret-name #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 6, 2022
Merged

Start deprecation of --secret-name #215

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion cmd/webhook/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,8 @@ import (
cwebhook "github.com/sigstore/policy-controller/pkg/webhook"
)

var secretName = flag.String("secret-name", "", "The name of the secret in the webhook's namespace that holds the public key for verification.")
// Deprecated: this flag will be removed in the future
var secretName = flag.String("secret-name", "", "Flag -secret-name has been deprecated and will be removed in the future. The name of the secret in the webhook's namespace that holds the public key for verification.")

// webhookName holds the name of the validating and mutating webhook
// configuration resources dispatching admission requests to policy-controller.
Expand Down
1 change: 1 addition & 0 deletions config/webhook.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ spec:
# and substituted here.
image: ko://github.com/sigstore/policy-controller/cmd/webhook
args: [
# DEPRECATED: -secret-name will be removed in the future.
"-secret-name=verification-key",
# Uncomment these to initialize with a custom TUF root.
# TODO: How to specify the entire TUF directory for multiple
Expand Down